Refactor test structure#50
Merged
brycekbargar merged 17 commits intolibrary-data-platform:v4.0.0from Sep 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests had been setup with all the cases in one location, then each database having its own file to arrange/act/assert based on those cases. A few things precipitated an inversion where now the test cases are split up among files and the test logic is shared between databases.
As part of this refactor the slow-running integration tests are now filterable based on the Integration name. I've also mad the end to end tests run against both duckdb and postgres. There's also lots of misc database and sql cleanup pieces where I wasn't using the libraries in the best ways before.